[LUCENE-5723] Performance improvements for FastCharStream

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: core/queryparser
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Itamar Syn-Hershko
• Created: 01/Jun/14 03:18
• Updated: 28/Aug/22 14:08

Description

Hello from the .NET land,

A user of ours has identified an optimization opportunity, although minor I think it points to a valid point - we should avoid using exceptions from controlling flow when possible.

Here's the original ticket + commits to our codebase. If this looks valid to you too I can go ahead and prepare a PR.

https://issues.apache.org/jira/browse/LUCENENET-541
https://github.com/apache/lucene.net/commit/ac8c9fa809110ddb180bf7b2ce93e86270b39ff6
https://git-wip-us.apache.org/repos/asf?p=lucenenet.git;a=blobdiff;f=src/core/QueryParser/QueryParserTokenManager.cs;h=ec09c8e451f7a7d1572fbdce4c7598e362526a7c;hp=17583d20f660fdb6e4aa86105c7574383f965ebe;hb=41ebbc2d;hpb=ac8c9fa809110ddb180bf7b2ce93e86270b39ff6