Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.9, 6.0
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Related to LUCENE-5708 we keep state in the MP holding on to the IW which prevents sharing the MP across index writers. Aside of this we should really not keep state in the MP it should really only select merges without being bound to the index writer.

      1. LUCENE-5711.patch
        51 kB
        Simon Willnauer

        Activity

        Hide
        Simon Willnauer added a comment -

        here is a patch

        Show
        Simon Willnauer added a comment - here is a patch
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Shai Erera added a comment -

        Note that this was changed in LUCENE-1763. At the time there were issues with some MPs that didn't treat it well, but I don't remember what issues. It also helped clean up the API, since I think most apps don't share an MP between writers. But then again, most people also don't write their own MPs, or interact with it directly, so the API is less of an issue. If it works and allows to share an MP between writers more easily, let's go for it.

        Show
        Shai Erera added a comment - Note that this was changed in LUCENE-1763 . At the time there were issues with some MPs that didn't treat it well, but I don't remember what issues. It also helped clean up the API, since I think most apps don't share an MP between writers. But then again, most people also don't write their own MPs, or interact with it directly, so the API is less of an issue. If it works and allows to share an MP between writers more easily, let's go for it.
        Hide
        ASF subversion and git services added a comment -

        Commit 1598833 from Simon Willnauer in branch 'dev/trunk'
        [ https://svn.apache.org/r1598833 ]

        LUCENE-5711: Pass IndexWriter to MergePolicy on each operation

        Show
        ASF subversion and git services added a comment - Commit 1598833 from Simon Willnauer in branch 'dev/trunk' [ https://svn.apache.org/r1598833 ] LUCENE-5711 : Pass IndexWriter to MergePolicy on each operation
        Hide
        ASF subversion and git services added a comment -

        Commit 1598834 from Simon Willnauer in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1598834 ]

        LUCENE-5711: Pass IndexWriter to MergePolicy on each operation

        Show
        ASF subversion and git services added a comment - Commit 1598834 from Simon Willnauer in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1598834 ] LUCENE-5711 : Pass IndexWriter to MergePolicy on each operation
        Hide
        ASF subversion and git services added a comment -

        Commit 1598853 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1598853 ]

        LUCENE-5711: fix solr tests

        Show
        ASF subversion and git services added a comment - Commit 1598853 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1598853 ] LUCENE-5711 : fix solr tests
        Hide
        ASF subversion and git services added a comment -

        Commit 1598854 from Michael McCandless in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1598854 ]

        LUCENE-5711: fix solr tests

        Show
        ASF subversion and git services added a comment - Commit 1598854 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1598854 ] LUCENE-5711 : fix solr tests

          People

          • Assignee:
            Simon Willnauer
            Reporter:
            Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development