Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.9, 6.0
    • Component/s: core/store
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This method is extraneous: it just makes the API confusing. Its not actually used anywhere by Lucene, so it shouldn't be mandatory on IndexOutput.

      Maybe it had some use-case before things were append-only, i dont know, but now its time for it to go.

        Activity

        Hide
        Robert Muir added a comment -

        patch. The MDW disk full test was using this to force that disk full tripped at a specific time, but i just changed the test to use close() instead.

        DirectPostingsFormat was calling RAMDir's flush() directly before writeTo(), but writeTo() already calls it internally.

        Show
        Robert Muir added a comment - patch. The MDW disk full test was using this to force that disk full tripped at a specific time, but i just changed the test to use close() instead. DirectPostingsFormat was calling RAMDir's flush() directly before writeTo(), but writeTo() already calls it internally.
        Hide
        Michael McCandless added a comment -

        Big +1!

        Show
        Michael McCandless added a comment - Big +1!
        Hide
        ASF subversion and git services added a comment -

        Commit 1588739 from rmuir@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1588739 ]

        LUCENE-5621: remove IndexOutput.flush

        Show
        ASF subversion and git services added a comment - Commit 1588739 from rmuir@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1588739 ] LUCENE-5621 : remove IndexOutput.flush
        Hide
        ASF subversion and git services added a comment -

        Commit 1588740 from rmuir@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1588740 ]

        LUCENE-5621: remove IndexOutput.flush

        Show
        ASF subversion and git services added a comment - Commit 1588740 from rmuir@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1588740 ] LUCENE-5621 : remove IndexOutput.flush
        Hide
        ASF subversion and git services added a comment -

        Commit 1588741 from rmuir@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1588741 ]

        LUCENE-5621: Let DirectPF and RAMOutputStream wreak havoc together if they like

        Show
        ASF subversion and git services added a comment - Commit 1588741 from rmuir@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1588741 ] LUCENE-5621 : Let DirectPF and RAMOutputStream wreak havoc together if they like
        Hide
        ASF subversion and git services added a comment -

        Commit 1588742 from rmuir@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1588742 ]

        LUCENE-5621: revert: the bug is not mine

        Show
        ASF subversion and git services added a comment - Commit 1588742 from rmuir@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1588742 ] LUCENE-5621 : revert: the bug is not mine

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development