[LUCENE-561] ParallelReader fails on deletes and on seeks of previously unused fields

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: core/index

Environment

All

• Assignee: Yonik Seeley
• Reporter: Chuck Williams
• Created: 02/May/06 05:08
• Updated: 15/Sep/24 22:24
• Resolved: 19/May/06 23:40

Description

In using ParallelReader I've hit two bugs:

1. ParallelReader.doDelete() and doUndeleteAll() call doDelete() and doUndeleteAll() on the subreaders, but these methods do not set hasChanges. Thus the changes are lost when the readers are closed. The fix is to call deleteDocument() and undeleteAll() on the subreaders instead.

2. ParallelReader discovers the fields in each subindex by using IndexReader.getFieldNames() which only finds fields that have occurred on at least one document. In general a parallel index is designed with assignments of fields to sub-indexes and term seeks (including searches) may be done on any of those fields, even if no documents in a particular state of the index have yet had an assigned field. Seeks/searches on fields that have not yet been indexed generated an NPE in ParallelReader's various inner class seek() and next() methods because fieldToReader.get() returns null on the unseen field. The fix is to extend the add() methods to supply the correct list of fields for each subindex.

Patch that corrects both of these issues attached.