[LUCENE-5388] Eliminate construction over readers for Tokenizer

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Component/s: core/other
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Benson Margulies
• Created: 07/Jan/14 21:47
• Updated: 28/Aug/22 13:58
• Resolved: 09/Jan/14 13:32

Description

In the modern world, Tokenizers are intended to be reusable, with input supplied via #setReader. The constructors that take Reader are a vestige. Worse yet, they invite people to make mistakes in handling the reader that tangle them up with the state machine in Tokenizer. The sensible thing is to eliminate these ctors, and force setReader usage.