Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-526

FieldSortedHitQueue - subsequent String sorts with different locales sort identically

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.0.0
    • Component/s: core/search
    • Labels:
      None

      Description

      From my own post to the java-user list. I have looked into this further and am sure it's a bug.

      It seems to me that there's a possible bug in FieldSortedHitQueue, specifically in getCachedComparator(). This is showing up on our 1.4.3 install, but it seems from source code inspection that if it's a bug, it's in 1.9.1 also.

      The issue shows up when you need to sort results from a given IndexReader multiple times, using different locales. On line 180 (all line numbers from the 1.9.1 code), we have this:

      ScoreDocComparator comparator = lookup (reader, fieldname, type, factory);

      Then, if no comparator is found in the cache, a new one is created (line 193) and then stored in the cache (line 202). HOWEVER, both the cache lookup() and store() do NOT take into account locale; if we, on the same index reader, try to do one search sorted by Locale.FRENCH and one by Locale.ITALIAN, the first one will result in a cache miss, a new French comparator will be created, and stored in the cache. Second time through, lookup() finds the cached French comparator – even though this time, the locale parameter to getCachedComparator() is an Italian locale. Therefore, we don't create a new comparator and we use the wrong one to sort the results.

      It looks to me (unless I'm mistaken) that the FieldCacheImpl.Entry class should have an additional property, .locale, to ensure that different locales get different comparators.

      Patch (well, most of one) to follow immediately.

        Attachments

        1. LUCENE-526-d.txt
          1 kB
          Paul Cowan
        2. LUCENE-526-c.txt
          5 kB
          Paul Cowan
        3. LUCENE-526-b.txt
          12 kB
          Paul Cowan
        4. LUCENE-526.txt
          12 kB
          Paul Cowan

          Activity

            People

            • Assignee:
              yseeley@gmail.com Yonik Seeley
              Reporter:
              pcowan Paul Cowan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: