Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4, master
    • Component/s: modules/test-framework
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Currently MockDirWrapper always calls delegate.sync() with a comment that we can relax this to not wear out the hardware for tests. The issue, as discussed on this thread http://lucene.markmail.org/thread/eozdsbdahzhjvizj, is related to NRTCachingDirectory and RateLimiter. The improvements I'd like to make under this issue are:

      • Call delgeate.sync() if:
        • rarely()
        • delegate is NRTCachingDir
        • delegate is RateLimitedDirWrapper and its delegate is NRTCachingDir
        • delegate is TrackingDirWrapper and its delegate is NRTCachingDir
      • Also, today the method either fails to sync all files or succeeds. Rather, we can improve this to randomly throw IOE on each file.

      Any other Directories that can cause issues when sync() isn't called?

      1. LUCENE-4990.patch
        4 kB
        Shai Erera
      2. LUCENE-4990.patch
        4 kB
        Shai Erera
      3. LUCENE-4990.patch
        4 kB
        Shai Erera

        Activity

        Steve Rowe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Shai Erera made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Lucene Fields New [ 10121 ] New,Patch Available [ 10121, 10120 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.4 [ 12324323 ]
        Resolution Fixed [ 1 ]
        Shai Erera made changes -
        Attachment LUCENE-4990.patch [ 12582499 ]
        Shai Erera made changes -
        Attachment LUCENE-4990.patch [ 12582464 ]
        Shai Erera made changes -
        Field Original Value New Value
        Attachment LUCENE-4990.patch [ 12582424 ]
        Shai Erera created issue -

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development