Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4974

CommitIndexTask is broken if no params are set

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.3.1, 6.0
        • Component/s: modules/benchmark
        • Labels:
          None
        • Lucene Fields:
          New, Patch Available

          Description

          If you put a CommitIndex in a benchmark algorithm with no params, you get NPE from IW.setCommitData, because you are not allowed to pass null. It's a trivial fix - CommitIndexTask should call setCommitData only if commitData is not null.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            shaie Shai Erera added a comment -

            Test + trivial fix. I will commit shortly.

            Show
            shaie Shai Erera added a comment - Test + trivial fix. I will commit shortly.
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] shaie
            http://svn.apache.org/viewvc?view=revision&revision=1478273

            LUCENE-4974: CommitIndexTask broken if no params are set

            Show
            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] shaie http://svn.apache.org/viewvc?view=revision&revision=1478273 LUCENE-4974 : CommitIndexTask broken if no params are set
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] shaie
            http://svn.apache.org/viewvc?view=revision&revision=1478275

            LUCENE-4974: CommitIndexTask broken if no params are set

            Show
            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] shaie http://svn.apache.org/viewvc?view=revision&revision=1478275 LUCENE-4974 : CommitIndexTask broken if no params are set
            Hide
            Permalink
            shaie Shai Erera added a comment -

            Committed to trunk and 4x.

            Show
            shaie Shai Erera added a comment - Committed to trunk and 4x.
            Hide
            Permalink
            steve_rowe Steve Rowe added a comment -

            If there are no objections, I'd like to backport this to 4.3.1.

            Show
            steve_rowe Steve Rowe added a comment - If there are no objections, I'd like to backport this to 4.3.1.
            Hide
            Permalink
            shalinmangar Shalin Shekhar Mangar added a comment -

            Back ported to 4.3.1 r1483349.

            Show
            shalinmangar Shalin Shekhar Mangar added a comment - Back ported to 4.3.1 r1483349.
            Hide
            Permalink
            shalinmangar Shalin Shekhar Mangar added a comment -

            Bulk closing after 4.3.1 release

            Show
            shalinmangar Shalin Shekhar Mangar added a comment - Bulk closing after 4.3.1 release

              People

              • Assignee:
                shaie Shai Erera
                Reporter:
                shaie Shai Erera
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development