Lucene - Core
  1. Lucene - Core
  2. LUCENE-4967

Absorb NRTManager entirely into a separate reopen thread class

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4, 5.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I think NRTManager can be drastically simplified by moving all of its
      logic into a new reopen thread class. All logic for waiting for a
      specific generation and reopening at different rates would live in
      this class.

      This would fully decouple the "wait for generation X to be visible"
      from which particular ReferenceManager impl you're using, which would
      make it possible to use the controlled consistency approach of
      NRTManager with any managers (e.g. SearcherTaxonomyManager).

      1. LUCENE-4967.patch
        64 kB
        Michael McCandless

        Activity

        Michael McCandless created issue -
        Hide
        Michael McCandless added a comment -

        Patch, I think it's ready.

        Show
        Michael McCandless added a comment - Patch, I think it's ready.
        Michael McCandless made changes -
        Field Original Value New Value
        Attachment LUCENE-4967.patch [ 12580914 ]
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1478438

        LUCENE-4967: move NRTManager entirely into a reopen thread so it can interact with any ReferenceManager

        Show
        Commit Tag Bot added a comment - [trunk commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1478438 LUCENE-4967 : move NRTManager entirely into a reopen thread so it can interact with any ReferenceManager
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1478446

        LUCENE-4967: move NRTManager entirely into a reopen thread so it can interact with any ReferenceManager

        Show
        Commit Tag Bot added a comment - [branch_4x commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1478446 LUCENE-4967 : move NRTManager entirely into a reopen thread so it can interact with any ReferenceManager
        Michael McCandless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues
        Steve Rowe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development