[LUCENE-4899] FastVectorHighlihgter fails with SIOOB if single phrase or term is > fragCharSize

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0, 4.1, 4.2, 3.6.2, 4.2.1
• Fix Version/s: 4.3, 6.0
• Component/s: modules/highlighter
• Lucene Fields: New, Patch Available
• Assignee: Simon Willnauer
• Reporter: Simon Willnauer
• Created: 03/Apr/13 08:54
• Updated: 28/Aug/22 13:43
• Resolved: 05/Apr/13 16:57

Description

This has been reported on several occasions like SOLR-4660 / SOLR-4137 or on the ES mailing list https://groups.google.com/d/msg/elasticsearch/IdyMSPK5gao/nKZq8_NYWmgJ

The reason is that the current code expects the fragCharSize > matchLength which is not necessarily true if you use phrases or if you have very long terms like URLs or so. I have a test that reproduces the issue and a fix as far as I can tell (me doesn't have much experience with the highlighter.

Issue Links

• supercedes: SOLR-4660 FastVectorHighlighter: String Out of bounds exception when phrase query with a fairly big slop is used (pf is used in edismax)
• supercedes: SOLR-4137 FastVectorHighlighter: StringIndexOutOfBoundsException in BaseFragmentsBuilder