Lucene - Core
  1. Lucene - Core
  2. LUCENE-4853

PostingsHighlighter should let you pass in docids directly [expert]

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3, 5.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today it just takes TopDocs, which is very convenient, except if you are doing grouping and you have a TopGroups.

      I think it should let you pass in int[] docIDs ...

      1. LUCENE-4853.patch
        4 kB
        Michael McCandless
      2. LUCENE-4853.patch
        9 kB
        Michael McCandless
      3. LUCENE-4853.patch
        6 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Patch.

        Show
        Michael McCandless added a comment - Patch.
        Hide
        Michael McCandless added a comment -

        Patch, fixing Solr's PostingsSolrHighlighter to pass int[] instead of faking up a TopDocs ...

        Show
        Michael McCandless added a comment - Patch, fixing Solr's PostingsSolrHighlighter to pass int[] instead of faking up a TopDocs ...
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1458016

        LUCENE-4853: PostingsHighlighter: add method that takes int[] docIDs

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1458016 LUCENE-4853 : PostingsHighlighter: add method that takes int[] docIDs
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1458014

        LUCENE-4853: PostingsHighlighter: add method that takes int[] docIDs

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1458014 LUCENE-4853 : PostingsHighlighter: add method that takes int[] docIDs
        Hide
        Michael McCandless added a comment -

        This fix broke the order of the returned highlights ...

        Show
        Michael McCandless added a comment - This fix broke the order of the returned highlights ...
        Hide
        Michael McCandless added a comment -

        Patch w/ test & fix.

        Show
        Michael McCandless added a comment - Patch w/ test & fix.
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1458944

        LUCENE-4853: fix sort order bug with returned snippets

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1458944 LUCENE-4853 : fix sort order bug with returned snippets
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1458951

        LUCENE-4853: fix param name

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1458951 LUCENE-4853 : fix param name
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1458949

        LUCENE-4853: fix sort order bug with returned snippets

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1458949 LUCENE-4853 : fix sort order bug with returned snippets
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1458950

        LUCENE-4853: fix param name

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1458950 LUCENE-4853 : fix param name
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development