Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3, 5.0
    • Component/s: general/test
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The idea is similar to Base[Postings/DocValues/TermVectors]TestCase.

      We ensure each codec has certain checks and its easier to maintain and also easier to ensure new impls are correct.

      For example hunting around today, a lot of the best tests are actually tucked away in TestCompressingStoredFieldsFormat.

      1. LUCENE-4852.patch
        55 kB
        Robert Muir
      2. LUCENE-4852_prototype.patch
        36 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -

        here's just where i am so far, just scavenging stored tests from where i can find. I still havent ported all the ones from .compressing package yet.

        Show
        Robert Muir added a comment - here's just where i am so far, just scavenging stored tests from where i can find. I still havent ported all the ones from .compressing package yet.
        Hide
        Robert Muir added a comment -

        updated patch. I think this is close... adrien do you know of any other tests we should steal and put in here?

        Show
        Robert Muir added a comment - updated patch. I think this is close... adrien do you know of any other tests we should steal and put in here?
        Hide
        Adrien Grand added a comment -

        Patch looks good!

        Show
        Adrien Grand added a comment - Patch looks good!
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1457926

        LUCENE-4852: BaseStoredFieldsFormatTestCase

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1457926 LUCENE-4852 : BaseStoredFieldsFormatTestCase
        Hide
        Robert Muir added a comment -

        I committed this as a start. Hopefully we add more test methods to this base class!

        Show
        Robert Muir added a comment - I committed this as a start. Hopefully we add more test methods to this base class!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1457931

        LUCENE-4852: BaseStoredFieldsFormatTestCase

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1457931 LUCENE-4852 : BaseStoredFieldsFormatTestCase
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development