Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3, 6.0
    • Component/s: modules/facet
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      ParallelTaxonomyArrays, while appearing on TaxonomyReader, actually support only one implementation, that of DirectoryTaxonomyReader. I'd like to make it abstract (perhaps share the children/siblings arrays computation) to allow for other taxonomy reader implementations.

        Activity

        Hide
        Shai Erera added a comment -

        In fact, ParallelTaxonomyArrays exists under o.a.l.facet.taxonomy.directory package, while it should be under the *.taxonomy one.

        Show
        Shai Erera added a comment - In fact, ParallelTaxonomyArrays exists under o.a.l.facet.taxonomy.directory package, while it should be under the *.taxonomy one.
        Hide
        Shai Erera added a comment -

        Patch moves PTA under o.a.l.taxonomy with a concrete impl under *.directory (basically the previous PTA impl). Most of the changes are due the package move, but functionality hasn't changed.

        Running few tests and i plan to commit this soon.

        Show
        Shai Erera added a comment - Patch moves PTA under o.a.l.taxonomy with a concrete impl under *.directory (basically the previous PTA impl). Most of the changes are due the package move, but functionality hasn't changed. Running few tests and i plan to commit this soon.
        Hide
        Shai Erera added a comment -

        Committed to trunk and 4x.

        Show
        Shai Erera added a comment - Committed to trunk and 4x.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Shai Erera
        http://svn.apache.org/viewvc?view=revision&revision=1457810

        LUCENE-4849: make ParallelTaxonomyArrays abstract

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Shai Erera http://svn.apache.org/viewvc?view=revision&revision=1457810 LUCENE-4849 : make ParallelTaxonomyArrays abstract
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Shai Erera
        http://svn.apache.org/viewvc?view=revision&revision=1457807

        LUCENE-4849: make ParallelTaxonomyArrays abstract

        Show
        Commit Tag Bot added a comment - [trunk commit] Shai Erera http://svn.apache.org/viewvc?view=revision&revision=1457807 LUCENE-4849 : make ParallelTaxonomyArrays abstract
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development