Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Component/s: general/build
-
Labels:None
-
Lucene Fields:New, Patch Available
Description
Right now, 'ant compile' at the top level compiles Lucene core, all non-test Solr sources, and all Lucene modules on which Solr depends. lucene/codecs/, e.g., doesn't get compiled, because 'ant compile' is an alias for 'ant compile-core' under lucene/.
Similarly for 'ant jar' (except there is no top-level target for this right now), with some problems under solr/.
There is no top-level 'ant compile-test'.
All these targets should recurse at all levels.
Under lucene/ and solr/, 'ant jar-core' and 'ant compile-core' should be aliased to running the operation under core/.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Patch.
In the new lucene/build.xml in the patch, does 'compile' actually compile test-framework?
the 'jar' target seems more clear that everything is jar'ed (including test-framework)
In the new lucene/build.xml in the patch, does 'compile' actually compile test-framework?
No, it doesn't. I intentionally left it out - it seems pretty clear to me that test-framework belongs in the same bucket as */src/test/**, which gets compiled via 'ant compile-test'. (I should go test that assumption 
).
the 'jar' target seems more clear that everything is jar'ed (including test-framework)
Yeah, test-framework jar is externally consumable, so excluding it from 'ant jar' seemed wrong.
OK: in any case I just wanted to make sure it was intentional. Maybe just add a comment?
+1 to commit this though.
[...] test-framework belongs in the same bucket as */src/test/**, which gets compiled via 'ant compile-test'. (I should go test that assumption
'ant compile-test' under lucene/ recurses properly, and triggers compilation of test-framework; similarly under solr/. But there is no top-level 'ant compile-test'. I'll add it.
OK: in any case I just wanted to make sure it was intentional. Maybe just add a comment?
Good idea, I'll do that.
Patch: 'ant compile-test' enabled at top-level; and comments added above 'compile' targets noting test-framework(s) compilation exclusion.
Committing shortly.
[trunk commit] Steven Rowe
http://svn.apache.org/viewvc?view=revision&revision=1443094
LUCENE-4758: 'ant jar', 'ant compile' and 'ant compile-test' should recurse
Committed to trunk and branch_4x.
Thanks for the review Robert!
[branch_4x commit] Steven Rowe
http://svn.apache.org/viewvc?view=revision&revision=1443110
LUCENE-4758: 'ant jar', 'ant compile' and 'ant compile-test' should recurse (merged trunk r1443094)
Closed after release.
+1, man is this confusing.
It should be dead simple to compile all the code and make jars for lucene. compile in /lucene/ should NOT be a alias for compile-core (imo), instead it should recurse across all modules. Same with jar (not an alias for jar-core).
Separately the confusion a user has when they run 'ant -p' (e.g. from lucene): there is a huge list of targets but which one should i use to just compile stuff or make jars? some of these should probably be hidden (separate issue: LUCENE-4416). But we can fix this separately of course!