Lucene - Core
  1. Lucene - Core
  2. LUCENE-4690

Optimize NumericUtils.*ToPrefixCoded(), add versions that don't hash

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, Trunk
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      As far as I can tell nothing actually uses the hash codes generated by these methods (not even any tests). If someone did want to generate a hash, it would be just as fast to do it on the BytesRef after the fact (or even faster from the input number itself).

      edit: Uwe pointed out they were used in one place. Other places still don't need it.

      1. LUCENE-4690.patch
        17 kB
        Yonik Seeley

        Activity

        Yonik Seeley created issue -
        Yonik Seeley made changes -
        Field Original Value New Value
        Attachment LUCENE-4690.patch [ 12566206 ]
        Yonik Seeley made changes -
        Summary remove hashing from NumericUtils.*ToPrefixCoded Optimize NumericUtils.*ToPrefixCoded(), add versions that don't hash
        Priority Major [ 3 ] Minor [ 4 ]
        Description As far as I can tell nothing actually uses the hash codes generated by these methods (not even any tests). If someone did want to generate a hash, it would be just as fast to do it on the BytesRef after the fact (or even faster from the input number itself). As far as I can tell nothing actually uses the hash codes generated by these methods (not even any tests). If someone did want to generate a hash, it would be just as fast to do it on the BytesRef after the fact (or even faster from the input number itself).

        edit: Uwe pointed out they were used in one place. Other places still don't need it.
        Yonik Seeley made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.2 [ 12323899 ]
        Fix Version/s 5.0 [ 12321663 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development