[LUCENE-4671] CharsRef.subSequence broken

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.1, 3.6.3, 6.0
• Lucene Fields: New
• Assignee: Robert Muir
• Reporter: Tim Smith
• Created: 09/Jan/13 18:32
• Updated: 28/Aug/22 13:35
• Resolved: 09/Jan/13 19:54

Description

Looks like CharsRef.subSequence() is currently broken

It is implemented as:

  @Override
  public CharSequence subSequence(int start, int end) {
    // NOTE: must do a real check here to meet the specs of CharSequence
    if (start < 0 || end > length || start > end) {
      throw new IndexOutOfBoundsException();
    }
    return new CharsRef(chars, offset + start, offset + end);
  }

Since CharsRef constructor is (char[] chars, int offset, int length),
Should Be:

  @Override
  public CharSequence subSequence(int start, int end) {
    // NOTE: must do a real check here to meet the specs of CharSequence
    if (start < 0 || end > length || start > end) {
      throw new IndexOutOfBoundsException();
    }
    return new CharsRef(chars, offset + start, end - start);
  }