[LUCENE-4355] improve AtomicReader sugar apis

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0, 6.0
• Lucene Fields: New
• Assignee: Robert Muir
• Reporter: Robert Muir
• Created: 04/Sep/12 11:45
• Updated: 28/Aug/22 13:26
• Resolved: 13/Sep/12 11:55

Description

I thought about this after looking @ LUCENE-4353:

AtomicReader has some sugar APIs that are over top of the flex apis (Fields, Terms, ...). But these might be a little trappy/confusing compared to 3.x.

1. I dont think we need AtomicReader.termDocsEnum(Bits, ...) and .termPositionsEnum(Bits, ...). I also don't think we need variants that take flags here. We should simplify these to be less trappy. I think we only need (String, BytesRef) here.
2. This means you need to use the flex apis for more expert usage: but we make this a bit too hard since we only let you get a Terms (which you must null check, then call .iterator() on, then seekExact, ...). I think it could help if we balanced this out by adding some sugar like AtomicReader.termsEnum? 3.x had a method that let you get a 'positioned termsenum'.