Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4240

Analyzer.getOffsetGap Improvements

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0-BETA, 6.0
    • None
    • None
    • New

    Description

      From LUCENE-3151 (Robert Muir's comments): there is no need for the Analyzer to take in an IndexableField object. We can simplify this API:

      Hey Grant: I know it sounds silly but can we split out the getOffsetGap API change into a separate issue?
      This would be nice to fix ASAP.

      I dont understand why it takes IndexableField or took Fieldable. All the other methods here like
      getPositionIncrementGap take "String fieldName". I think this one should too.

      I dont think it needs a boolean for tokenized either: returning a 0 for NOT_ANALYZED fields.
      If you choose NOT_ANALYZED, that should mean the Analyzer is not invoked!

      If you want to do expert stuff control the offset gaps between values for NOT_ANALYZED fields,
      then just analyze it instead, with keyword tokenizer!

      Attachments

        1. LUCENE-4240.patch
          5 kB
          Robert Muir

        Activity

          People

            Unassigned Unassigned
            gsingers Grant Ingersoll
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: