[LUCENE-3899] Evil up MockDirectoryWrapper.checkIndexOnClose

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.6, 4.0-ALPHA
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 21/Mar/12 13:58
• Updated: 28/Aug/22 13:11
• Resolved: 21/Mar/12 15:24

Description

MockDirectoryWrapper checks any indexes tests create on close(), if they exist.

The problem is the logic it uses to determine if an index exists could mask real bugs (e.g. segments file corrumption):

if (DirectoryReader.indexExists(this) {
  ...
  // evil stuff like crash()
  ...
  _TestUtil.checkIndex(this)
}

and for reference DirectoryReader.indexExists is:

try {
  new SegmentInfos().read(directory);
  return true;
} catch (IOException ioe) {
  return false;
}

So if there are segments file problems, we just silently do no checkIndex.