Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Really we should add this for Sep & Pulsing too... but this is one more

      1. LUCENE-3864.patch
        19 kB
        Robert Muir
      2. LUCENE-3864.patch
        19 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -

        patch mostly works... TestPostingsOffsets passes but now i see that term-vectors cross-compare is awesome...

        so there's still another bug.

        Show
        Robert Muir added a comment - patch mostly works... TestPostingsOffsets passes but now i see that term-vectors cross-compare is awesome... so there's still another bug.
        Hide
        Robert Muir added a comment -

        stupid bug: not returning -1 for startOffset when they aren't available.

        CheckIndex only wraps its entire offsets check in if (hasOffsets), which was confusing to me, but thats referring to whether the vectors have offsets...

        (in other words my postings impl can return -1 always for offsets and checkindex is happy..., in fact there are no assertions for postings offsets at all!)

        Show
        Robert Muir added a comment - stupid bug: not returning -1 for startOffset when they aren't available. CheckIndex only wraps its entire offsets check in if (hasOffsets), which was confusing to me, but thats referring to whether the vectors have offsets... (in other words my postings impl can return -1 always for offsets and checkindex is happy..., in fact there are no assertions for postings offsets at all!)
        Hide
        Robert Muir added a comment -

        to improve checkindex: i guess there really isn't much we can enforce, but I think in testPostings we should
        at least try to pull a docsAndPositions(offsets=true) if they are available.

        in the case they aren't available we can also assert -1 for start and end offset, which would have caught my bug

        Show
        Robert Muir added a comment - to improve checkindex: i guess there really isn't much we can enforce, but I think in testPostings we should at least try to pull a docsAndPositions(offsets=true) if they are available. in the case they aren't available we can also assert -1 for start and end offset, which would have caught my bug
        Hide
        Michael McCandless added a comment -

        Patch looks good!

        Show
        Michael McCandless added a comment - Patch looks good!
        Hide
        Robert Muir added a comment -

        thanks for reviewing Mike

        Show
        Robert Muir added a comment - thanks for reviewing Mike

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development