Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3769

Simplify NRTManager

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.6, 4.0-ALPHA
    • core/search
    • None
    • New

    Description

      NRTManager is hairy now, because the applyDeletes is separately passed
      to ctor, passed to maybeReopen, passed to getSearcherManager, etc.

      I think, instead, you should pass it only to the ctor, and if you have
      some cases needing deletes and others not then you can make two
      NRTManagers. This should be no less efficient than we have today,
      just simpler.

      I think it will also enable NRTManager to subclass ThingyManager
      (LUCENE-3761).

      Attachments

        1. LUCENE-3769.patch
          36 kB
          Michael McCandless
        2. LUCENE-3769.patch
          36 kB
          Michael McCandless

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mikemccand Michael McCandless
            mikemccand Michael McCandless
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment