Lucene - Core
  1. Lucene - Core
  2. LUCENE-3679

Replace IndexReader.getFieldNames with IndexReader.getFieldInfos

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New
    1. LUCENE-3679.patch
      112 kB
      Michael McCandless
    2. LUCENE-3679.patch
      109 kB
      Michael McCandless

      Activity

      Hide
      Michael McCandless added a comment -

      We already have FieldInfo/s to record which fields were indexed; I
      think we should make this public (experimental) to replace
      IR.getFieldNames(FieldOption).

      Show
      Michael McCandless added a comment - We already have FieldInfo/s to record which fields were indexed; I think we should make this public (experimental) to replace IR.getFieldNames(FieldOption).
      Hide
      Michael McCandless added a comment -

      Patch, tests pass. I think it's ready!

      Show
      Michael McCandless added a comment - Patch, tests pass. I think it's ready!
      Hide
      Michael McCandless added a comment -

      New patch; I fixed the composite readers to throw UOE from getFieldInfos, to match how I port to 4.0. I added ReaderUtil.getMergedFieldInfos(IR) as sugar to do the merging from the subs...

      I think it's ready.

      Show
      Michael McCandless added a comment - New patch; I fixed the composite readers to throw UOE from getFieldInfos, to match how I port to 4.0. I added ReaderUtil.getMergedFieldInfos(IR) as sugar to do the merging from the subs... I think it's ready.
      Hide
      Simon Willnauer added a comment -

      patch looks good to me!

      Show
      Simon Willnauer added a comment - patch looks good to me!

        People

        • Assignee:
          Michael McCandless
          Reporter:
          Michael McCandless
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development