[LUCENE-3513] Add SimpleFragListBuilder constructor with margin parameter

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.9
• Fix Version/s: 3.5, 4.0-ALPHA
• Component/s: modules/highlighter
• Lucene Fields: New
• Assignee: Koji Sekiguchi
• Reporter: Kelsey Francis
• Created: 12/Oct/11 15:32
• Updated: 28/Aug/22 12:59
• Resolved: 16/Oct/11 04:03

Description

SimpleFragListBuilder would benefit from an additional constructor that takes in margin. Currently, the margin is defined as a constant, so to "implement" a FragListBuilder with a different margin, one has no choice but to copy and paste SimpleFragListBuilder into a new class that must be placed in the org.apache.lucene.search.vectorhighlight package due to accesses of package-protected fields in other classes.

If this change were made, the precondition check of the constructor's fragCharSize should probably be altered to ensure that it's less than max(1, margin*3) to allow for a margin of 0.