Maybe we just shouldn't ever call warm from the ctor? Caller can easily call warm themselves... we can just jdoc this.
Also, I remember there was a ctor which took IndexWriter, to allow for an NRT-SearcherManager. What happened to it?
Right, I removed it because we have NRTManager now.
Mike, would it be possible to merge the NRT and SearcherManager into one class / manager or that maybe both implement the same interface?
Right, they used to be merged.... we could consider merging them again?
NRTManager is more feature-full, though, because it offers add/updateDocument(s) APIs that invoke the writer but return a [long] gen, which you can then turnaround and pass to .get() to ensure the returned searcher includes those changes. SearcherManager doesn't have notion... unless we somehow tie in the IndexReader.getVersion() somehow? I'm torn... they seem different enough that maybe they should remain separate. Plus, users usually know quite strongly if they use NRT or not and could pick the right manager accordingly...