[LUCENE-3410] Make WordDelimiterFilter's instantiation more readable

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.5, 4.0-ALPHA
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Chris Male
• Reporter: Chris Male
• Created: 31/Aug/11 16:00
• Updated: 27/Nov/11 12:29
• Resolved: 07/Sep/11 04:43

Description

Currently WordDelimiterFilter's constructor is:

public WordDelimiterFilter(TokenStream in,
	                             byte[] charTypeTable,
	                             int generateWordParts,
	                             int generateNumberParts,
	                             int catenateWords,
	                             int catenateNumbers,
	                             int catenateAll,
	                             int splitOnCaseChange,
	                             int preserveOriginal,
	                             int splitOnNumerics,
	                             int stemEnglishPossessive,
	                             CharArraySet protWords) {

which means its instantiation is an unreadable combination of 1s and 0s.

We should improve this by either using a Builder, 'int flags' or an EnumSet.