Details

    • Lucene Fields:
      New

      Description

      Move the contents of lucene/src/java/org/apache/lucene/queryParser to the queryparser module.

      To differentiate these parsers from the others, they are going to be placed a 'classic' package. We'll rename QueryParser to ClassicQueryParser as well.

      1. LUCENE-3283.patch
        91 kB
        Chris Male
      2. LUCENE-3283.patch
        113 kB
        Chris Male
      3. LUCENE-3283.patch
        121 kB
        Chris Male
      4. LUCENE-3283.patch
        122 kB
        Chris Male

        Activity

        Hide
        Chris Male added a comment -

        Patch which creates the queryparser module, moves the core QueryParsers into the classic package, updates dependencies throughout the code. Code will compile in intellij but not ant, eclipse or maven just yet.

        Pending:

        • Fix ant dependencies in modules which depend on the queryparser module
        • Add eclipse and maven support for new module.
        • Move javacc building stuff into queryparser/build.xml
        • Update migrate.txt
        Show
        Chris Male added a comment - Patch which creates the queryparser module, moves the core QueryParsers into the classic package, updates dependencies throughout the code. Code will compile in intellij but not ant, eclipse or maven just yet. Pending: Fix ant dependencies in modules which depend on the queryparser module Add eclipse and maven support for new module. Move javacc building stuff into queryparser/build.xml Update migrate.txt
        Hide
        Chris Male added a comment -

        Command for patch:

        svn --parents mkdir modules/queryparser/src/java/org/apache/lucene/queryparser/classic
        svn --parents mkdir modules/queryparser/src/test/org/apache/lucene/queryparser/classic
        svn move lucene/src/java/org/apache/lucene/queryParser/* modules/queryparser/src/java/org/apache/lucene/queryparser/classic/
        svn move lucene/src/test/org/apache/lucene/queryParser/* modules/queryparser/src/test/org/apache/lucene/queryparser/classic/
        
        Show
        Chris Male added a comment - Command for patch: svn --parents mkdir modules/queryparser/src/java/org/apache/lucene/queryparser/classic svn --parents mkdir modules/queryparser/src/test/org/apache/lucene/queryparser/classic svn move lucene/src/java/org/apache/lucene/queryParser/* modules/queryparser/src/java/org/apache/lucene/queryparser/classic/ svn move lucene/src/test/org/apache/lucene/queryParser/* modules/queryparser/src/test/org/apache/lucene/queryparser/classic/
        Hide
        Chris Male added a comment -

        New patch:

        • ant dependencies are fixed
        • eclipse and maven support added
        • javacc building support moved to queryparser/build.xml (untested)

        Everything compiles and test pass.

        I'll verify that the javacc building works while I wait for anybody to review.

        Show
        Chris Male added a comment - New patch: ant dependencies are fixed eclipse and maven support added javacc building support moved to queryparser/build.xml (untested) Everything compiles and test pass. I'll verify that the javacc building works while I wait for anybody to review.
        Hide
        Chris Male added a comment -

        Javacc support works.

        Show
        Chris Male added a comment - Javacc support works.
        Hide
        Chris Male added a comment -

        Command to clean up left over directories:

        svn delete lucene/src/java/org/apache/lucene/queryParser/*
        svn delete lucene/src/test/org/apache/lucene/queryParser/*
        
        Show
        Chris Male added a comment - Command to clean up left over directories: svn delete lucene/src/java/org/apache/lucene/queryParser/* svn delete lucene/src/test/org/apache/lucene/queryParser/*
        Hide
        Chris Male added a comment -

        New patch which fixes javadoc errors introduced. Also includes MIGRATE.txt change.

        At the completion of the queryparser consolidations, I'm going to open an issue to look at all the documentation in the codebase since alot of it refers to QueryParser.

        Show
        Chris Male added a comment - New patch which fixes javadoc errors introduced. Also includes MIGRATE.txt change. At the completion of the queryparser consolidations, I'm going to open an issue to look at all the documentation in the codebase since alot of it refers to QueryParser.
        Hide
        Chris Male added a comment -

        New patch updated to trunk.

        I'm seeing some unrelated test failures on trunk so I'm going to wait for those to be resolved before committing this large change.

        Show
        Chris Male added a comment - New patch updated to trunk. I'm seeing some unrelated test failures on trunk so I'm going to wait for those to be resolved before committing this large change.
        Hide
        Michael McCandless added a comment -

        I'm seeing some unrelated test failures on trunk so I'm going to wait for those to be resolved before committing this large change.

        Was this LUCENE-3303 or is there something else?

        Show
        Michael McCandless added a comment - I'm seeing some unrelated test failures on trunk so I'm going to wait for those to be resolved before committing this large change. Was this LUCENE-3303 or is there something else?
        Hide
        Chris Male added a comment -

        Just that one, thanks Mike!

        Show
        Chris Male added a comment - Just that one, thanks Mike!
        Hide
        Chris Male added a comment -

        Committed revision 1145016.

        I'm going to rename this QueryParser to ClassicQueryParser in a separate issue.

        Show
        Chris Male added a comment - Committed revision 1145016. I'm going to rename this QueryParser to ClassicQueryParser in a separate issue.

          People

          • Assignee:
            Chris Male
            Reporter:
            Chris Male
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development