Lucene - Core
  1. Lucene - Core
  2. LUCENE-3161

consider warnings from the source compilation

    Details

    • Lucene Fields:
      New

      Description

      as Doron mentioned in his review: At compiling there are various warning printed, I think it would be more assuring for downloaders if the build runs without warning. These warnings are not a stopper.

      we could conditionalize these warnings so that they don't "display" when compiling from actual releases, but I have to wonder if we should hide these... being open source I think we should display all our warts, maybe some contributor sees these warnings and decides they want to submit a patch to fix some of them.

        Activity

        Hide
        Uwe Schindler added a comment -

        Move issue to Lucene 4.9.

        Show
        Uwe Schindler added a comment - Move issue to Lucene 4.9.
        Hide
        Steve Rowe added a comment -

        Bulk move 4.4 issues to 4.5 and 5.0

        Show
        Steve Rowe added a comment - Bulk move 4.4 issues to 4.5 and 5.0
        Hide
        Doron Cohen added a comment -

        And, I don't think we should in general hide any warnings, even to users for the reasons i mentioned above.

        +1 for not hiding!

        Show
        Doron Cohen added a comment - And, I don't think we should in general hide any warnings, even to users for the reasons i mentioned above. +1 for not hiding!
        Hide
        Robert Muir added a comment -

        I committed the SuppressWarnings("dep-ann") with a note in revs 1129465, 1129466 (branch3x), 1129467 (branch32).

        I'll keep the issue open for future improvements like possibly upgrading javacc.

        Show
        Robert Muir added a comment - I committed the SuppressWarnings("dep-ann") with a note in revs 1129465, 1129466 (branch3x), 1129467 (branch32). I'll keep the issue open for future improvements like possibly upgrading javacc.
        Hide
        Robert Muir added a comment -

        There are currently 18 warnings in lucene if you use java 6, all of which are in generated code:

        • jflex generates fallthrough warnings
        • javacc generates dep-ann and redundant cast warnings.

        Additionally on java 5-only, you will get a dep-ann warning for Version.java, which is actually a JDK bug.
        I'll commit a workaround for this issue, as its the only one in our code.

        In the future, the javacc dep-ann warnings can be reduced by upgrading to the latest javacc, which generates java-5 compatible code.
        I say reduced because on java 5 it hits the same bug as above... and it still has redundant casts.

        I don't think at this time we should be upgrading any of our code generators though, so I think a workaround for our Version.java is the best solution.
        And, I don't think we should in general hide any warnings, even to users for the reasons i mentioned above.

        Show
        Robert Muir added a comment - There are currently 18 warnings in lucene if you use java 6, all of which are in generated code: jflex generates fallthrough warnings javacc generates dep-ann and redundant cast warnings. Additionally on java 5-only, you will get a dep-ann warning for Version.java, which is actually a JDK bug. I'll commit a workaround for this issue, as its the only one in our code. In the future, the javacc dep-ann warnings can be reduced by upgrading to the latest javacc, which generates java-5 compatible code. I say reduced because on java 5 it hits the same bug as above... and it still has redundant casts. I don't think at this time we should be upgrading any of our code generators though, so I think a workaround for our Version.java is the best solution. And, I don't think we should in general hide any warnings, even to users for the reasons i mentioned above.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development