Lucene - Core
  1. Lucene - Core
  2. LUCENE-3126

IndexWriter.addIndexes can make any incoming segment into CFS if it isn't already

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2, 4.0-ALPHA
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Today, IW.addIndexes(Directory) does not modify the CFS-mode of the incoming segments. However, if IndexWriter's MP wants to create CFS (in general), there's no reason why not turn the incoming non-CFS segments into CFS. We anyway copy them, and if MP is not against CFS, we should create a CFS out of them.

      Will need to use CFW, not sure it's ready for that w/ current API (I'll need to check), but luckily we're allowed to change it (@lucene.internal).

      This should be done, IMO, even if the incoming segment is large (i.e., passes MP.noCFSRatio) b/c like I wrote above, we anyway copy it. However, if you think otherwise, speak up .

      I'll take a look at this in the next few days.

      1. LUCENE-3126.patch
        15 kB
        Shai Erera
      2. LUCENE-3126.patch
        11 kB
        Shai Erera

        Activity

        Shai Erera created issue -
        Shai Erera made changes -
        Field Original Value New Value
        Assignee Shai Erera [ shaie ]
        Shai Erera made changes -
        Attachment LUCENE-3126.patch [ 12480102 ]
        Shai Erera made changes -
        Attachment LUCENE-3126.patch [ 12480256 ]
        Shai Erera made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Robert Muir made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development