Lucene - Core
  1. Lucene - Core
  2. LUCENE-2549

TimeLimitingCollector's TimeExceededException contains useless relative docid

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.9, 2.9.1, 2.9.2, 2.9.3, 3.0, 3.0.1, 3.0.2
    • Fix Version/s: 2.9.4, 3.0.3, 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      We found another bug with the RandomIndexWriter: When TimeLimitingCollector breaks collection after timeout, it records the last/next collected docid. It does this without rebasing, so the docid is useless. TestTimeLimitingCollector checks the docid, but correctly rebases it (as only this makes sense). Because the RandomIndexWriter uses different merge settings, the index is now sometimes not optimized and so the test fails (which is correct, as the docid is useless for non-optimized index).

      Attached is a patch that fixes this. Please tell me if I should backport to 2.9 and 3.0!

      1. LUCENE-2549.patch
        2 kB
        Uwe Schindler

        Activity

        Hide
        Uwe Schindler added a comment -

        Committed 3.0 branch revision: 1028920
        Committed 2.9 branch revision: 1028922

        Show
        Uwe Schindler added a comment - Committed 3.0 branch revision: 1028920 Committed 2.9 branch revision: 1028922
        Hide
        Robert Muir added a comment -

        reopening for possible 2.9.4/3.0.3 backport.

        Show
        Robert Muir added a comment - reopening for possible 2.9.4/3.0.3 backport.
        Hide
        Uwe Schindler added a comment -

        Committed trunk revision: 965299
        Committed 3.x revision: 965300

        Please reopen if we should backport to 2.9 or 3.0!

        Show
        Uwe Schindler added a comment - Committed trunk revision: 965299 Committed 3.x revision: 965300 Please reopen if we should backport to 2.9 or 3.0!

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development