[LUCENE-2315] AttributeSource's methods for accessing attributes should be final, else its easy to corrupt the internal states

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.9, 2.9.1, 2.9.2, 3.0, 3.0.1
• Fix Version/s: 4.0-ALPHA
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 13/Mar/10 14:38
• Updated: 10/May/13 14:45
• Resolved: 27/Feb/11 17:42

Description

The methods that operate and modify the internal maps of AttributeSource should be final, which is a backwards break. But anybody that overrides such methods simply creates a buggy AS either case.

I want to makeall impls final (in general the class should be final at all, but it is made for extension in TokenStream). So its important that the implementations are final!