Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2315

AttributeSource's methods for accessing attributes should be final, else its easy to corrupt the internal states

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.9, 2.9.1, 2.9.2, 3.0, 3.0.1
    • 4.0-ALPHA
    • modules/analysis
    • None
    • New

    Description

      The methods that operate and modify the internal maps of AttributeSource should be final, which is a backwards break. But anybody that overrides such methods simply creates a buggy AS either case.

      I want to makeall impls final (in general the class should be final at all, but it is made for extension in TokenStream). So its important that the implementations are final!

      Attachments

        Activity

          People

            uschindler Uwe Schindler
            uschindler Uwe Schindler
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: