Lucene - Core
  1. Lucene - Core
  2. LUCENE-2278

FastVectorHighlighter: highlighted term is out of alignment in multi-valued NOT_ANALYZED field

    Details

    • Lucene Fields:
      New
    1. LUCENE-2278.patch
      8 kB
      Koji Sekiguchi

      Activity

      Hide
      Koji Sekiguchi added a comment -

      Fix and a test case attached.

      Show
      Koji Sekiguchi added a comment - Fix and a test case attached.
      Hide
      Digy added a comment -

      Besides passing docid+fieldname to FVH, can there be another method that accepts the original text to be highlighted?
      like:

      	getBestFragment( final FieldQuery fieldQuery, IndexReader reader, String originalText, int fragCharSize ) 
      

      So, the field content can be stored outside of lucene resulting in a smaller index.

      DIGY

      Show
      Digy added a comment - Besides passing docid+fieldname to FVH, can there be another method that accepts the original text to be highlighted? like: getBestFragment( final FieldQuery fieldQuery, IndexReader reader, String originalText, int fragCharSize ) So, the field content can be stored outside of lucene resulting in a smaller index. DIGY
      Hide
      Koji Sekiguchi added a comment -

      getBestFragment() method needs docId and fieldName in order to get a TermPositionVector object from IndexReader when trying to make snippets.

      FVH could be acceptable an array of String so that it can make snippets from String[] outside of Lucene, rather than stored values. But it is out of this thread.

      Show
      Koji Sekiguchi added a comment - getBestFragment() method needs docId and fieldName in order to get a TermPositionVector object from IndexReader when trying to make snippets. FVH could be acceptable an array of String so that it can make snippets from String[] outside of Lucene, rather than stored values. But it is out of this thread.
      Hide
      Koji Sekiguchi added a comment -

      I'll commit in a few days.

      Show
      Koji Sekiguchi added a comment - I'll commit in a few days.
      Hide
      Koji Sekiguchi added a comment -

      Committed revision 916090.

      Show
      Koji Sekiguchi added a comment - Committed revision 916090.
      Hide
      Robert Muir added a comment -

      reopening for possible 2.9.4/3.0.3 backport.

      Show
      Robert Muir added a comment - reopening for possible 2.9.4/3.0.3 backport.
      Hide
      Koji Sekiguchi added a comment -

      Committed revision 1028833(2.9), 1028839(3.0).

      Show
      Koji Sekiguchi added a comment - Committed revision 1028833(2.9), 1028839(3.0).

        People

        • Assignee:
          Koji Sekiguchi
          Reporter:
          Koji Sekiguchi
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development