Details
-
Task
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
None
-
New
Description
All other contrib streams/filters have already been converted with LUCENE-1460.
The two shingle filters are the last ones we need to convert.
Attachments
Attachments
Issue Links
- is related to
-
LUCENE-1903 Incorrect ShingleFilter behavior when outputUnigrams == false
- Patch Available
First half is done:
ShingleFilter and ShingleFilterTest are converted to the new API.
ShingleFilter is much more efficient now, it clones much less often and computes the tokens mostly on the fly now.
Would be good if someone could review my changes.
We still need to convert ShingleMatrixFilter.