[LUCENE-1762] Slightly more readable code in Token/TermAttributeImpl

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.9
• Fix Version/s: 2.9
• Component/s: modules/analysis
• Lucene Fields: New, Patch Available
• Assignee: Uwe Schindler
• Reporter: Eks Dev
• Created: 25/Jul/09 13:21
• Updated: 28/Aug/22 12:04
• Resolved: 29/Jul/09 19:15

Description

No big deal.

growTermBuffer(int newSize) was using correct, but slightly hard to follow code.

the method was returning null as a hint that the current termBuffer has enough space to the upstream code or reallocated buffer.

this patch simplifies logic making this method to only reallocate buffer, nothing more.
It reduces number of if(null) checks in a few methods and reduces amount of code.
all tests pass.

This also adds tests for the new basic attribute impls (copies of the Token tests).