Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.9
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      IndexWriter offers a commit(String commitUserData) method.
      IndexReader can commit as well using the flush/close methods and so
      needs an analogous method that accepts commitUserData.

      1. LUCENE-1546.patch
        7 kB
        Michael McCandless
      2. LUCENE-1546.patch
        7 kB
        Jason Rutherglen
      3. LUCENE-1546-deprecation.patch
        2 kB
        Uwe Schindler

        Activity

        Hide
        Jason Rutherglen added a comment -

        All tests pass.

        • Added IndexReader.flush(userCommitData). I'm hesitant about adding
          IR.close(userCommitData) as IndexWriter.close doesn't have a similar
          method.
        Show
        Jason Rutherglen added a comment - All tests pass. Added IndexReader.flush(userCommitData). I'm hesitant about adding IR.close(userCommitData) as IndexWriter.close doesn't have a similar method.
        Hide
        Michael McCandless added a comment -

        I tweaked the patch to keep back compat (we can't just change IndexReader's protected doCommit() method). I think it's ready to commit... I'll wait a day or two.

        Show
        Michael McCandless added a comment - I tweaked the patch to keep back compat (we can't just change IndexReader's protected doCommit() method). I think it's ready to commit... I'll wait a day or two.
        Hide
        Michael McCandless added a comment -

        Committed revision 748493. Thanks Jason!

        Show
        Michael McCandless added a comment - Committed revision 748493. Thanks Jason!
        Hide
        Uwe Schindler added a comment -

        This patch fixes deprecation errors:
        I wrote a class extends FilterIndexReader. This class produced on compilation an deprecation warning on doCommit() without any hint to this method in my code (I did not implement doCommit nor used the method).
        It seems, that javac from 1.5 needs the deprecation also in the subclasses. With this patch applied, the own subclass did not produce the warning anymore.

        Show
        Uwe Schindler added a comment - This patch fixes deprecation errors: I wrote a class extends FilterIndexReader. This class produced on compilation an deprecation warning on doCommit() without any hint to this method in my code (I did not implement doCommit nor used the method). It seems, that javac from 1.5 needs the deprecation also in the subclasses. With this patch applied, the own subclass did not produce the warning anymore.
        Hide
        Michael McCandless added a comment -

        OK I just committed that, thanks Uwe.

        Show
        Michael McCandless added a comment - OK I just committed that, thanks Uwe.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Jason Rutherglen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development