Lucene - Core
  1. Lucene - Core
  2. LUCENE-1357

SpanScorer does not respect ConstantScoreRangeQuery setting

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      ConstantScoreRangeQuery is actually on and can't be disabled when it should default to off with the option to turn it on.

        Activity

        Hide
        Mark Miller added a comment -

        Well this is annoying - the test for this counted on the setting being on - which was what the bug was - the setting was always on. But the fix is not so simple - the setting actually needs to be set before the constructor. I don't like the lazy load option for a few reasons, and that leaves dropping the setter, getter and adding new constructors (there are already too many), or just making the accessor methods static and docing so that users know to call the setter first and that its a global setting. I am leaning towards making the methods static and global as the best option with the least amount of changes.

        Show
        Mark Miller added a comment - Well this is annoying - the test for this counted on the setting being on - which was what the bug was - the setting was always on. But the fix is not so simple - the setting actually needs to be set before the constructor. I don't like the lazy load option for a few reasons, and that leaves dropping the setter, getter and adding new constructors (there are already too many), or just making the accessor methods static and docing so that users know to call the setter first and that its a global setting. I am leaning towards making the methods static and global as the best option with the least amount of changes.
        Hide
        Michael McCandless added a comment -

        Mark, do you have a concrete patch for this one? Should we defer beyond 2.4?

        Show
        Michael McCandless added a comment - Mark, do you have a concrete patch for this one? Should we defer beyond 2.4?
        Hide
        Mark Miller added a comment -

        Ill put it up today...just wanted to make sure anyone had a chance to complain.

        Show
        Mark Miller added a comment - Ill put it up today...just wanted to make sure anyone had a chance to complain.

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development