[LUCENE-10632] Change getAllChildren to return all children regardless of the count

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: modules/facet
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Yuting Gan
• Created: 30/Jun/22 06:46
• Updated: 28/Aug/22 16:42

Description

Currently, the getAllChildren functionality is implemented in a way that is similar to getTopChildren, where they only return children with count that is greater than zero.

However, he original getTopChildren in RangeFacetCounts returned all children whether-or-not the count was zero. This actually has good use cases and we should continue supporting the feature in getAllChildren, so that we will not lose it after properly supporting getTopChildren in RangeFacetCounts.

As discussed with gsmiller in the LUCENE-10614 pr, allowing getAllChildren to behave differently from getTopChildren can actually be more helpful for users. If users want to get children with only positive count, we have getTopChildren supporting this behavior already. Therefore, the getAllChildren API should provide all children in all of the implementations, whether-or-not the count is zero.