[LUCENE-10553] WANDScorer's handling of 0 and +Infty is backwards

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.2
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Adrien Grand
• Created: 02/May/22 13:01
• Updated: 28/Aug/22 16:40
• Resolved: 19/May/22 13:11

Description

WANDScorer has special logic to deal with corner cases when the sum of the maximum scores of sub queries is either 0 or +Infty, but both code and tests have backwards logic regarding this special case, doing +1 instead of -1 and vice-versa.

This leads to a failed assertion in the case when the sum of the scores of the sub queries overflows, which typically happens if one of the clauses has a default implementation that returns MAX_VALUE if it cannot reason about max scores.

Issue Links

• links to: GitHub Pull Request #860