[LUCENE-10505] Cleanup oal.util.Constants to use java.lang.Runtime.Version and remove outdated versions

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 9.0, 9.1, 10.0 (main)
• Component/s: core/other
• Labels: cleanup
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Uwe Schindler
• Created: 07/Apr/22 07:50
• Updated: 28/Aug/22 16:38

Description

In oal.util.Constants we have some constants about the 64 bitness and Java version and vendor info. Especially theres also parsing of system properties to get major and minor Java version.

We should change this in main and 9.x to use https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Runtime.html#version() and the corresponding Runtime.Version class. The Runtime.Version class also allows to compare in a safe way. The good thing is that you also get minor bugfix info, so code could disable stuff exactly at specific versions that are buggy.

We should also cleanup the constants. In 9.x and main we still have JRE_IS_MINIMUM_JAVA8! We should remove this constants (+ deprecate in 9.x and set to true) and change all code relying on the to execute code for java 8. Same for 11 and 17.