[LUCENE-10474] Avoid throwing StackOverflowError when creating RegExp

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: core/other
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Yannick Welsch
• Created: 18/Mar/22 07:43
• Updated: 28/Aug/22 16:37

Description

Creating a regular expression using Lucene's RegExp class can easily result in a StackOverflowError being thrown, for example when the input is larger than the maximum stack depth. Throwing a StackOverflowError isn't something a user would expect, and it isn't documented either. StackOverflowError is a user-unfriendly exception as it does not convey any intent that the user has done something wrong, but suggests a bug in the implementation.

I would like Lucene to follow the approach taken by the JDK and throw an IllegalArgumentException instead to clearly mark this as an input that the implementation can't handle.

Issue Links

• links to: GitHub Pull Request #752