[LUCENE-10464] unnecessary for-loop in WeightedSpanTermExtractor.extractWeightedSpanTerms

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.0 (main), 8.11.2, 9.2
• Lucene Fields: New
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 14/Mar/22 17:53
• Updated: 28/Aug/22 16:37
• Resolved: 22/Mar/22 15:19

Description

The https://github.com/apache/lucene/commit/81c7ba4601a9aaf16e2255fe493ee582abe72a90 change in LUCENE-4728 included

- final SpanQuery rewrittenQuery = (SpanQuery) spanQuery.rewrite(getLeafContextForField(field).reader());
+ final SpanQuery rewrittenQuery = (SpanQuery) spanQuery.rewrite(getLeafContext().reader());

i.e. previously more needed to happen in the loop but now the query rewrite and term collecting need not happen in the loop.

Issue Links

• is related to: LUCENE-4728 Allow CommonTermsQuery to be highlighted
• relates to: LUCENE-10477 SpanBoostQuery.rewrite was incomplete for boost==1 factor
• links to: GitHub Pull Request #737
• links to: GitHub Pull Request #2656
• links to: https://github.com/apache/lucene/pull/737