Lucene - Core
  1. Lucene - Core
  2. LUCENE-1015

FieldCache should support longs and doubles

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core/search
    • Labels:
      None

      Description

      Would be nice if FieldCache supported longs and doubles

      1. LUCENE-1015.patch
        24 kB
        Grant Ingersoll
      2. LUCENE-1015.patch
        15 kB
        Grant Ingersoll

        Issue Links

          Activity

          Hide
          Grant Ingersoll added a comment -

          Of course, since FieldCache is an interface, we need to think about back-compatibility...

          Show
          Grant Ingersoll added a comment - Of course, since FieldCache is an interface, we need to think about back-compatibility...
          Hide
          Grant Ingersoll added a comment -

          First draft at a patch to add long and double FieldCache support by extending the FieldCache interface (can't just add b/c of back-compatibility reasons). Adds support in the SortField and the two HItQueue's. Still needs to be more thoroughly tested, but wanted to get comments first.

          Show
          Grant Ingersoll added a comment - First draft at a patch to add long and double FieldCache support by extending the FieldCache interface (can't just add b/c of back-compatibility reasons). Adds support in the SortField and the two HItQueue's. Still needs to be more thoroughly tested, but wanted to get comments first.
          Hide
          Mark Miller added a comment -

          Finishing up LUCENE-831 would seem like a good way to add this as well – while also getting the juicy benefits of 831 combined with 743. Of course, this only applies if someone where to finish 831 and it where accepted...

          Show
          Mark Miller added a comment - Finishing up LUCENE-831 would seem like a good way to add this as well – while also getting the juicy benefits of 831 combined with 743. Of course, this only applies if someone where to finish 831 and it where accepted...
          Hide
          Grant Ingersoll added a comment - - edited

          I am going to commit this sometime tomorrow unless there are objections. It doesn't sound like anyone is stepping up on 831 at the moment, so they can refactor as necessary.

          Will also add in the necessary testing.

          Show
          Grant Ingersoll added a comment - - edited I am going to commit this sometime tomorrow unless there are objections. It doesn't sound like anyone is stepping up on 831 at the moment, so they can refactor as necessary. Will also add in the necessary testing.
          Hide
          Brian Pinkerton added a comment -

          While you're at it, would you mind adding shorts as well? When you have a lot of docs in a collection the space savings realized by using shorts instead of ints can make a real difference in the number of docs supportable on a given hardware platform.

          Show
          Brian Pinkerton added a comment - While you're at it, would you mind adding shorts as well? When you have a lot of docs in a collection the space savings realized by using shorts instead of ints can make a real difference in the number of docs supportable on a given hardware platform.
          Hide
          Grant Ingersoll added a comment -

          Good idea, will do.

          Show
          Grant Ingersoll added a comment - Good idea, will do.
          Hide
          Grant Ingersoll added a comment -

          Actually, the FieldCache already supports byte and shorts.

          Show
          Grant Ingersoll added a comment - Actually, the FieldCache already supports byte and shorts.
          Hide
          Grant Ingersoll added a comment -

          Added tests, fixed some documentation bugs.

          Will commit tonight or tomorrow

          Show
          Grant Ingersoll added a comment - Added tests, fixed some documentation bugs. Will commit tonight or tomorrow
          Hide
          Grant Ingersoll added a comment -

          Committed.

          Show
          Grant Ingersoll added a comment - Committed.

            People

            • Assignee:
              Grant Ingersoll
              Reporter:
              Grant Ingersoll
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development