Commons Logging
  1. Commons Logging
  2. LOGGING-39

[logging] Ant build script does not create commons-logging-optional.jar

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Nightly Builds
    • Fix Version/s: 1.1.0
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      I was building JCL with ant and couldn't get a
      commons-logging-optional.jar to build when executing
      the build.xml in the root directory. Instead the
      optional classes would get included in
      commons-logging.jar.

      Looked into this and saw that the when the main
      build.xml called the build in the optional folder, it
      was passing along all its properties, thus overriding
      the optional version. I'll attach a patch that fixes
      this.

        Activity

        Hide
        Brian Stansberry added a comment -

        Created an attachment (id=14147)
        Patch so call to optional build does not pass through properties

        1) Main build script should not pass through properties to optional build
        target.
        2) Copy commons-logging.jar to the dist folder before calling the optional
        build so the jar is where the optional build classpath expects it.

        Show
        Brian Stansberry added a comment - Created an attachment (id=14147) Patch so call to optional build does not pass through properties 1) Main build script should not pass through properties to optional build target. 2) Copy commons-logging.jar to the dist folder before calling the optional build so the jar is where the optional build classpath expects it.
        Hide
        rdonkin@apache.org added a comment -

        Committed. Many Thanks.

        Robert

        Show
        rdonkin@apache.org added a comment - Committed. Many Thanks. Robert

          People

          • Assignee:
            Unassigned
            Reporter:
            Brian Stansberry
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development