[LOGGING-186] Use ServiceLoader class

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.3.0
• Assignee: Unassigned
• Reporter: Piotr Karwasz
• Created: 18/Oct/23 12:27
• Updated: 18/Oct/23 20:51
• Resolved: 18/Oct/23 20:51

Description

The current service loader code used by LogFactory predates the ServiceLoader class introduced in Java 6 by 4 years and is a simplified version of it.

This has many disadvantages:

• the service loader file can not have any comments, like a license header or the name of the tool that generated the service file. Commons Logging just takes the first line in the file and uses it as the class name,
• the Service Loader Mediator OSGi specification allows to use ServiceLoader in an OSGi environment, but it might ignore direct accesses to META-INF/services resources (cf. Apache Aries SPI Fly),
• in a JPMS environment, the META-INF/services file could even not be there and the service is declared in the module descriptor.

Issue Links

• links to: GitHub Pull Request #171