Uploaded image for project: 'Commons Logging'
  1. Commons Logging
  2. LOGGING-185

mvn verify should also be run as part of the github actions workflow

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.3.0
    • None

    Description

      mvn verify should be run as part of the build pipeline. 

      The integration tests are currently broken and I believe they have been since this PR was merged because it introduced static imports to org.junit.Assert which is not on the classpath when running mvn verify.

      There is also some incorrect config in the failsafe plugin.

      By reverting the change to both ParentFirstTestCase.java and SecurityForbiddenTestCase.java in that PR and fixing the pom I was able to successfully run the tests.

       

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            singingbush Samael Bate
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment