[LOGGING-163] BufferedReader is not closed properly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.1, 1.2
• Fix Version/s: 1.3.0
• Assignee: Gary D. Gregory
• Reporter: Kaloyan Spiridonov
• Created: 17/Oct/16 14:30
• Updated: 26/Jan/24 01:57
• Resolved: 17/Oct/16 17:28

Description

In LogFactory class at line 552 there is BufferedReader that is not closed properly. For example if rd.readLine(); throw an exception then the Reader will remain open.

 BufferedReader rd;
try {
    rd = new BufferedReader(new InputStreamReader(is, "UTF-8"));
 } catch (java.io.UnsupportedEncodingException e) {
     rd = new BufferedReader(new InputStreamReader(is));
}

String factoryClassName = rd.readLine();
rd.close();

In SimpleLog class at line 163 there is InputStream that is not closed properly.

        InputStream in = getResourceAsStream("simplelog.properties");
        if(null != in) {
            try {
                simpleLogProps.load(in);
                in.close();
            } catch(java.io.IOException e) {
                // ignored
            }
        }