Commons Logging
  1. Commons Logging
  2. LOGGING-126

Within Tomcat 5.x implementation, under Windows ONLY Commons-logging forbids hot deployment due to JAR locking

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0, 1.0.1, 1.0.3, 1.0.4, 1.1.0, 1.1.1
    • Fix Version/s: 1.1.2
    • Labels:
      None
    • Environment:

      Windows only

      Description

      To reproduce the problem:
      Create a WAR that contains a JAR that contains commons-logging.properties.
      Deploy this WAR to TOMCAT 5.x
      Try to redeploy it, it will fail

      This is due to the fact that LogFactory uses url.openStream to open this file , thus URLConnection will use an internal cache and this will provoke a lock on the file from Window.

      1. Patch.txt
        2 kB
        Philippe Mouawad

        Activity

        Hide
        Philippe Mouawad added a comment -

        This patch solves the issue by disabling the URLConnection cache.

        Show
        Philippe Mouawad added a comment - This patch solves the issue by disabling the URLConnection cache.
        Hide
        Simon Kitching added a comment -

        Thanks very much for the report and patch; well spotted! I've applied your patch with a couple of minor modifications.

        Could you please test logging trunk (or a nightly build)? If it works for you, please mark this issue as resolved - or just add a comment.

        Show
        Simon Kitching added a comment - Thanks very much for the report and patch; well spotted! I've applied your patch with a couple of minor modifications. Could you please test logging trunk (or a nightly build)? If it works for you, please mark this issue as resolved - or just add a comment.
        Hide
        Philippe Mouawad added a comment -

        I tested OK for me.
        Thanks for taking into account my contribution.
        Philippe

        Show
        Philippe Mouawad added a comment - I tested OK for me. Thanks for taking into account my contribution. Philippe
        Hide
        Simon Kitching added a comment -

        See LOGGING-127 for a followup patch to this patch..

        Show
        Simon Kitching added a comment - See LOGGING-127 for a followup patch to this patch..

          People

          • Assignee:
            Simon Kitching
            Reporter:
            Philippe Mouawad
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development