Commons Logging
  1. Commons Logging
  2. LOGGING-12

Jdk14Logger extremely slow due to method name extraction

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.3
    • Labels:
      None
    • Environment:

      Operating System: other
      Platform: Other

      Description

      The Jdk14Logger of Commons logging is extremely slow, even if logging is not
      enabled. This is due to the fact that an exception is created so that its stack
      trace can be used to determine the callers method name.

      Attached patch will surround the code with a logger.isLoggable(level) check, so
      that this is at least avoided when logging is not enabled. (though I would
      rather see that code completely removed)

        Activity

        Bruno Dumon created issue -
        Hide
        Bruno Dumon added a comment -

        Created an attachment (id=5444)
        patch for Jdk14Logger.java

        Show
        Bruno Dumon added a comment - Created an attachment (id=5444) patch for Jdk14Logger.java
        Hide
        Craig McClanahan added a comment -

        Fixed in nightly build 20030331, and upcoming 1.0.3 release. Thanks for the patch!

        Show
        Craig McClanahan added a comment - Fixed in nightly build 20030331, and upcoming 1.0.3 release. Thanks for the patch!
        Henri Yandell made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 18184 12340621
        Henri Yandell made changes -
        Affects Version/s unspecified [ 12311647 ]
        Assignee Jakarta Commons Developers Mailing List [ commons-dev@jakarta.apache.org ]
        Project Commons [ 12310458 ] Commons Logging [ 12310484 ]
        Key COM-470 LOGGING-12
        Component/s Logging [ 12311124 ]
        Henri Yandell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Dennis Lundberg made changes -
        Fix Version/s 1.0.3 [ 12311839 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Bruno Dumon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development