Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.1
    • Labels:
      None
    • Environment:

      Commons-Logging + Log4j

      Description

      During the last few days I had major problems trying to configure Commons-Logging + Log4j on Glassfish.
      It turned out to be related to Log4j UDPAppender, but it took me needlessly long time to verify the problem was indeed in Log4j and not in Commons-Logging, Glassfish or something else. Now, why am I posting it here then - I made a small modification which logs Log4j failures more precisely, instead of just:

      [LogFactoryImpl@14810083 from org.apache.catalina.loader.WebappClassLoader@1904280] Could not instantiate Log 'org.apache.commons.logging.impl.Log4JLogger' – java.lang.reflect.InvocationTargetException: null

      which explains, basically, nothing, you get for example:

      [LogFactoryImpl@14810083 from org.apache.catalina.loader.WebappClassLoader@1904280] Could not instantiate Log 'org.apache.commons.logging.impl.Log4JLogger' – java.lang.reflect.InvocationTargetException: null
      [LogFactoryImpl@14810083 from org.apache.catalina.loader.WebappClassLoader@1904280] ... InvocationTargetException: java.lang.ExceptionInInitializerError: null
      [LogFactoryImpl@14810083 from org.apache.catalina.loader.WebappClassLoader@1904280] ... ExceptionInInitializerError: java.lang.IllegalStateException: Property layout must be set for UDPAppender named appenderLocalhostUdp

      which states clearly that Log4j was indeed loaded, and the problem was in its configuration.
      All it does is expand those two exceptions if they occurred. It could be more general and more elegant, but this code should work in pre-1.4 Java.

      Could you please include it in next build of Commons-Logging?

      Attaching the patch text below.

      Greetings, Lilianne E. Blaze

      Index: LogFactoryImpl.java

          • D:\Work\Projects\Apache\commons-logging-custom\src\org\apache\commons\logging\impl\LogFactoryImpl.java Base (BASE)
          • D:\Work\Projects\Apache\commons-logging-custom\src\org\apache\commons\logging\impl\LogFactoryImpl.java Locally Modified (Based On LOCAL)
            ***************
          • 1362,1369 ****
          • 1362,1388 ----
            + logAdapterClassName + "' – "
            + discoveryFlaw.getClass().getName() + ": "
            + discoveryFlaw.getLocalizedMessage());
            + + if ( discoveryFlaw instanceof InvocationTargetException )
            Unknown macro: {+ InvocationTargetException ite = (InvocationTargetException)discoveryFlaw;+ Throwable cause = ite.getTargetException();+ logDiagnostic("... InvocationTargetException}

            + + }
            + if (!allowFlawedDiscovery)

            { throw new LogConfigurationException(discoveryFlaw); }

      Index: Log4JLogger.java

          • D:\Work\Projects\Apache\commons-logging-custom\src\org\apache\commons\logging\impl\Log4JLogger.java Base (BASE)
          • D:\Work\Projects\Apache\commons-logging-custom\src\org\apache\commons\logging\impl\Log4JLogger.java Locally Modified (Based On LOCAL)
            ***************
          • 77,84 ****
          • 77,86 ----
            // ------------------------------------------------------------

      static {
      +
      if (!Priority.class.isAssignableFrom(Level.class))

      { // nope, this is log4j 1.3, so force an ExceptionInInitializerError + // note - it still works with log4j 1.3.8-alpha throw new InstantiationError("Log4J 1.2 not available"); }

      ***************

          • 112,117 ****
          • 114,124 ----
            /** For use with a log4j factory.
            */
            public Log4JLogger(Logger logger )
            Unknown macro: {+ + if( logger == null ) { + throw new IllegalArgumentException("Warning - logger == null, possible Log4j misconfiguration?"); + }+ this.name = logger.getName(); this.logger=logger; }

        Issue Links

          Activity

          Hide
          Simon Kitching added a comment -

          correct "applies to" version.

          Show
          Simon Kitching added a comment - correct "applies to" version.
          Hide
          Simon Kitching added a comment -

          Original poster has confirmed the patch works for her.

          Show
          Simon Kitching added a comment - Original poster has confirmed the patch works for her.
          Hide
          Simon Kitching added a comment -

          Looks good to me. I've committed this patch (with a couple of extra checks for null causes).
          Thanks very much for your contribution.

          SVN commit: 476772 (LogFactoryImpl), 476774 (Log4JLogger).

          Could you please check that this works fine for you?

          Note for others: InvocationTargetException.getTargetException and ExceptionInInitializerError.getException both exist in jdk1.2.2 (supported platform for JCL).

          Show
          Simon Kitching added a comment - Looks good to me. I've committed this patch (with a couple of extra checks for null causes). Thanks very much for your contribution. SVN commit: 476772 (LogFactoryImpl), 476774 (Log4JLogger). Could you please check that this works fine for you? Note for others: InvocationTargetException.getTargetException and ExceptionInInitializerError.getException both exist in jdk1.2.2 (supported platform for JCL).

            People

            • Assignee:
              Simon Kitching
              Reporter:
              Lilianne E. Blaze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development