Commons Logging
  1. Commons Logging
  2. LOGGING-106

AccessControlException when loading LogFactory class without system properties permission

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.1
    • Labels:
      None

      Description

      The LogFactory static initializer calls createFactoryStore which calls System.getProperty. If the class doesn't have access rights to see system properties (eg when in an applet) then the LogFactory class cannot load, and hence the app is completely stuffed.

      I think the system property access should be wrapped in a try/catch, with any access failure behaving as if the propery is not set.

      In addition, we might want to use an AccessController in the static block so that a signed logging jar can be granted system property access [without having to grant all its callers that permission too].

        Activity

        Simon Kitching created issue -
        Hide
        Simon Kitching added a comment -

        Fixed by SVN r423654.

        Re the last paragraph above, using an AccessController too broadly is a security risk so this should not be done.

        Show
        Simon Kitching added a comment - Fixed by SVN r423654. Re the last paragraph above, using an AccessController too broadly is a security risk so this should not be done.
        Simon Kitching made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Simon Kitching made changes -
        Status Resolved [ 5 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Simon Kitching made changes -
        Fix Version/s 1.1.1 [ 12312160 ]
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Simon Kitching made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        151d 14h 48m 1 Simon Kitching 19/Nov/06 09:08
        Resolved Resolved Reopened Reopened
        36s 1 Simon Kitching 19/Nov/06 09:09
        Reopened Reopened Resolved Resolved
        11s 1 Simon Kitching 19/Nov/06 09:09
        Resolved Resolved Closed Closed
        11s 1 Simon Kitching 19/Nov/06 09:09

          People

          • Assignee:
            Unassigned
            Reporter:
            Simon Kitching
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development