Uploaded image for project: 'Log4cxx'
  1. Log4cxx
  2. LOGCXX-543

Some tests can fail when there is a "Q" in the pathname

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.13.0
    • Tests
    • None
    • Patch

    Description

      During updating Debian's autopkgtest I came across the problem that sometimes e.g the patternlayouttest fails with something like this:

      51/57 Test #15: patternlayouttest ......................***Failed    0.17 sec
      LC_CTYPE: C.UTF-8
      patternlayouttest   :  sed: file output/patternlayout.sed line 1: unknown option to `s'
      Line 363: Compare::compare(FILTERED, LOG4CXX_FILE("witness/patternLayout.10")) was expected to be true, was false.
      sed: file output/patternlayout.sed line 1: unknown option to `s'

      After some debugging into it, I figured out that "Q" is used as the seperator for sed and the patternlayouttest uses somewhere _FILE_ which ends up in an invalid sed expression. As autopkgtest copies the source tree to some mktemp-made directory, a "Q" can happen in the source path...

      The attached patch (I willl also make a PR) will make sure that any "Q"'s are escaped as "\Q" so that sed will not become unhappy.

       

       

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              coldtobi Tobias Frost
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: